New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mac ime crack #11576

Merged
merged 1 commit into from Jan 18, 2018

Conversation

Projects
None yet
7 participants
@dengyaolong
Contributor

dengyaolong commented Jan 5, 2018

this commit should merge and publish a new version in 1-7-x.

  1. because 1.7.10 still crash by IME input.
  2. 1.8.x still not stable, and lot of crash. In my product, crash increase from 0.8% to 3%...
  3. And now many developers in China(like me) build the instruction by custom. It's trouble!
@iolsen

This comment has been minimized.

Contributor

iolsen commented Jan 5, 2018

@electron/maintainers an IME crash would affect Atom and we hope to ship with Electron 1.7 in early February. Is this a known issue in Electron 1.7? We were unable to reproduce the crash in Atom on MacOS.

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Jan 6, 2018

This appears to be backporting #10393 into 1-7-x

The original reported issue says the issue was happening all the way back in 1.6.x so I'm not sure what exactly this could be fixing if Atom / others havn't been seeing this crash 🤔

@dengyaolong

This comment has been minimized.

Contributor

dengyaolong commented Jan 6, 2018

@MarshallOfSound @iolsen always crash in 1.7-x, reproduce steps:

  1. use Apple IME, pinyin
  2. copy 4066 char to input ( you can use like '我'.repeat(4066) )
  3. now you type '我'
  4. crash by OOM killer
@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Jan 6, 2018

@iolsen I'm happy to merge this if you can verify that OOM crash on 1.7.x 👍 I won't be able to try to repro the crash for a while 😄

@dengyaolong

This comment has been minimized.

Contributor

dengyaolong commented Jan 7, 2018

@iolsen @MarshallOfSound Only crash on mac 10.12

@iolsen

This comment has been minimized.

Contributor

iolsen commented Jan 8, 2018

@ungb can you look at reproducing the out-of-memory condition described above?

@ungb

This comment has been minimized.

ungb commented Jan 9, 2018

@dengyaolong @iolsen I can't repro this on Atom 1.25.0-dev-b5c939d5c(latest master) with 1.7.10.

I am running on mac 10.12:

image

I'm using pinyin simplified and am still unable to repro. I was following steps in #11576 (comment)

In step 3, I'm unsure what which key on my keyboard would generate '我'

Here's gif of what I tried:
jan-09-2018 13-41-00

@dengyaolong

This comment has been minimized.

Contributor

dengyaolong commented Jan 10, 2018

@ungb where can I download Atom 1.25.0-dev-b5c939d5c with 1.7.10?

I can reproduce in electron-quick-example (here's gif). An I think it will also crash in atom. may be you need to type more Chinese word.

ezgif-5-a2a3a0b60b

@50Wliu

This comment has been minimized.

@dengyaolong

This comment has been minimized.

Contributor

dengyaolong commented Jan 10, 2018

@50Wliu @iolsen @MarshallOfSound @ungb crash only occur in input/area tag. But in atom, it use First Mate, not a really input, so it wont have 4066 word. So, if you can find a input in atom and you can reproduce.
image

But in electron, many application has input/textarea , and will crash. like

#11576 (comment)

@dengyaolong

This comment has been minimized.

Contributor

dengyaolong commented Jan 14, 2018

@MarshallOfSound Atom won't crash because it do not use or <textarea>. But many product will use. crash can reproduce in 1.7.9.

ezgif-5-a2a3a0b60b

@j3l11234

This comment has been minimized.

j3l11234 commented Jan 17, 2018

╮(╯_╰)╭
I suffer from the same problem.

@zcbenz

zcbenz approved these changes Jan 18, 2018

This looks good to me since it is a straight backport.

@zcbenz zcbenz merged commit 97349eb into electron:1-7-x Jan 18, 2018

5 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@scottnonnenberg scottnonnenberg referenced this pull request Jan 22, 2018

Closed

Typing in Chinese sometimes causes app to close #1991

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment