New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix URLs and Paths #11584

Merged
merged 4 commits into from Jan 12, 2018

Conversation

Projects
None yet
4 participants

@TiagoDanin TiagoDanin requested a review from electron/docs as a code owner Jan 6, 2018

@ckerr

Lots of good stuff here, only question I have is about the removal of the testing.md link -- was that intentional?

Show outdated Hide outdated docs/README.md
@@ -1353,7 +1353,7 @@ Set the size of the page. This is only supported for `<webview>` guest contents.
* `options` Object
* `normal` Object (optional) - Normal size of the page. This can be used in
combination with the [`disableguestresize`](web-view-tag.md#disableguestresize)
combination with the [`disableguestresize`](webview-tag.md#disableguestresize)

This comment has been minimized.

@ckerr

ckerr Jan 9, 2018

Member

👍

@ckerr

ckerr Jan 9, 2018

Member

👍

@zeke

Thanks for the cleanup! Overall this looks great. Just a few minor things that need to be fixed before we can ship it.

@@ -107,6 +106,6 @@ an issue:
* [Debug Instructions (Windows)](development/debug-instructions-windows.md)
* [Setting Up Symbol Server in debugger](development/setting-up-symbol-server.md)
* [Documentation Styleguide](styleguide.md)
* [Upgrading Chrome](development/upgrading-chrome.md)
* [Upgrading Chromium](development/upgrading-chromium.md)

This comment has been minimized.

@zeke

zeke Jan 10, 2018

Member

In order to avoid breaking links, please create an empty file that links to the new file, using the following content:

echo "Moved to [upgrading-chromium.md](upgrading-chromium.md)" > updgrading-chrome.md
@zeke

zeke Jan 10, 2018

Member

In order to avoid breaking links, please create an empty file that links to the new file, using the following content:

echo "Moved to [upgrading-chromium.md](upgrading-chromium.md)" > updgrading-chrome.md
@@ -107,7 +107,7 @@ Follow all the steps above to fix Electron code on all supported platforms.
If there are any compilation errors related to the Crashpad, it probably means
you need to update the fork to a newer revision. See
[Upgrading Crashpad](https://github.com/electron/electron/tree/master/docs/development/upgrading-crashpad.md)
[Upgrading Crashpad](upgrading-crashpad.md)

This comment has been minimized.

@zeke

zeke Jan 10, 2018

Member

👍

@zeke

zeke Jan 10, 2018

Member

👍

TiagoDanin added some commits Jan 11, 2018

@TiagoDanin TiagoDanin changed the title from [WIP] [Docs] Fix URLs and Paths to [Docs] Fix URLs and Paths Jan 11, 2018

@zeke

zeke approved these changes Jan 12, 2018

@codebytere codebytere merged commit 74769da into electron:master Jan 12, 2018

6 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

kwonoj added a commit to kwonoj/electron that referenced this pull request Jan 25, 2018

[Docs] Fix URLs and Paths (electron#11584)
* Fix URLs and Paths in docs/

* Avoiding link break to /docs/development/updgrading-chrome.md

* Fix URLs and Paths in docs/ #2

* Removed double spaces in docs

@TiagoDanin TiagoDanin deleted the TiagoDanin-Forks:CheckDocs branch Apr 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment