New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use task scheduler for app.getFileIcon API #11595

merged 2 commits into from Feb 12, 2018


None yet
3 participants

YurySolovyov commented Jan 8, 2018

This updates icon loader to be closer to upstream Chromium state of things.

Related Chromium review entries:

@YurySolovyov YurySolovyov requested a review from electron/reviewers as a code owner Jan 8, 2018


LGTM, thanks!

@deepak1556 deepak1556 requested a review from zcbenz Feb 7, 2018


Code seems 👌

@MarshallOfSound MarshallOfSound merged commit 9f78ef0 into electron:master Feb 12, 2018

6 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/jenkins/pr-head This commit looks good

@YurySolovyov YurySolovyov deleted the YurySolovyov:fileicon-task-scheduler branch Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment