New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libcc in 1-8-x: Fix Shift not showing in menu for certain accelerators #11597

Merged
merged 1 commit into from Jan 8, 2018

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Jan 8, 2018

Backports #11589 to 1.8.x.

Refs electron/libchromiumcontent#431.

Update libcc: Fix Shift not showing
Fix the Shift key not showing in menu for certain accelerators like
Control+Shift+F.

@zcbenz zcbenz requested a review from electron/reviewers as a code owner Jan 8, 2018

@zcbenz zcbenz merged commit d0ca62b into 1-8-x Jan 8, 2018

7 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@zcbenz zcbenz deleted the fix-shift-key-shortcut branch Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment