New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macos Full Screen Toggle menu item label #11633

Merged
merged 1 commit into from Jan 19, 2018

Conversation

Projects
None yet
2 participants
@nitsakh
Contributor

nitsakh commented Jan 14, 2018

Fix for issue #11571 and probably #10575 as well.

The Full screen menu item on the mac is special and behaves unexpected.
I think macOS checks if we have an implementation for toggleFullScreen and then uses the default menu item label for it. This PR instead maps the togglefullscreen role to a different named method, so as to not confuse the OS, and enable changing the menu item label.

@nitsakh nitsakh requested a review from electron/reviewers as a code owner Jan 14, 2018

@codebytere

LGTM 👍

@nitsakh

This comment has been minimized.

Contributor

nitsakh commented Jan 14, 2018

@codebytere thoughts on why 2 of the checks are failing?

@codebytere

This comment has been minimized.

Member

codebytere commented Jan 14, 2018

@nitsakh arm-test is failing per #11621 and the other one is flaky i think; i'll re-run ia32 but arm-test is unrelated & non-blocking

@codebytere codebytere merged commit 2b4cc0a into electron:master Jan 19, 2018

7 of 8 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nitsakh nitsakh deleted the nitsakh:issue11571 branch Jan 19, 2018

kwonoj added a commit to kwonoj/electron that referenced this pull request Jan 25, 2018

sethlu added a commit to sethlu/electron that referenced this pull request May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment