Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Update gyp: Add Visual Studio 2017 support #11656
Jan 17, 2018
8 of 9 checks passed
Thanks for doing this change to support VS2017!
I encounter an issue 'could not locate Visual Studio installation' when execute ''python script\bootstrap.py -v --target_arch=ia32"
The script/update.py looks also need update. the GYP_MSVS_VERSION should be 2017, after I made this change, everything works well.
The failures like
VS 2017 is only required by the Chromium 63, so we don't need to change the