New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick devtools crash fix from master to 1-8-x #11673

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
5 participants
@brenca
Member

brenca commented Jan 19, 2018

The fix was pulled to master with #11233

@brenca brenca requested a review from electron/reviewers as a code owner Jan 19, 2018

@alexeykuzmin alexeykuzmin requested a review from ckerr Jan 19, 2018

@alexeykuzmin

This comment has been minimized.

Show comment
Hide comment
@alexeykuzmin

alexeykuzmin Jan 19, 2018

Contributor

@brenca Can you please add a link to a PR that fixed it in the master?

Contributor

alexeykuzmin commented Jan 19, 2018

@brenca Can you please add a link to a PR that fixed it in the master?

@brenca

This comment has been minimized.

Show comment
Hide comment
@brenca

brenca Jan 19, 2018

Member

@alexeykuzmin I've added it to the description.

Member

brenca commented Jan 19, 2018

@alexeykuzmin I've added it to the description.

@logidelic

This comment has been minimized.

Show comment
Hide comment
@logidelic

logidelic Jan 23, 2018

Surprised that this wasn't included in the 1.8.2-beta.4 release... Any chance for a quick merge/release with it?

logidelic commented Jan 23, 2018

Surprised that this wasn't included in the 1.8.2-beta.4 release... Any chance for a quick merge/release with it?

@codebytere codebytere merged commit 8d22014 into electron:1-8-x Jan 23, 2018

6 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment