Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use same screen capturer settings for thumbnails as getUserMedia (Chrome 59/1-8-x) #11677
This was referenced
Jan 20, 2018
@deepak1556: okay. Found the trouble. I think this is okay to merge.
First, there's a bug in the DirectX capturer when using it in a debug Electron because static variables can't cross shared library bounds. So you end up with two different
@MarshallOfSound correct, unfortunately. It seems to be a very narrow case, but I haven't explored it completely. If that's unacceptable, I may be able to carve out some time in the next week or two to try and figure it out. It's quite a bit harder to debug because the shared library build hides the issue with its own bug. The good news is that there is no crash in master, so there's probably a relevant WebRTC commit that I just haven't found yet.