Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve OSR API (master) #11728
This PR addresses bugs that came up in #11715 and contains some other small improvements
ckerr left a comment
I'll give a real review in the next few days when I have time to give this proper attention, but the first thing that sticks out to me is there aren't any tests to confirm that these changes work.
Could you please add some tests, e.g. to confirm the #11715 stop/start fixes?