New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in remote api docs #11758

Merged
merged 1 commit into from Jan 29, 2018

Conversation

Projects
None yet
3 participants
@nicknish
Contributor

nicknish commented Jan 27, 2018

Hey y'all, saw a tiny typo (I think!) in the remote api docs. Hope this helps!

@nicknish nicknish requested a review from electron/docs as a code owner Jan 27, 2018

@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Jan 27, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

welcome bot commented Jan 27, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@codebytere

i re-kicked CI as i don't think it's related, and in the event that everything is passing this looks good to merge.

@zeke zeke merged commit aea06ed into electron:master Jan 29, 2018

6 of 7 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Jan 29, 2018

Congrats on merging your first pull request! 🎉🎉🎉

welcome bot commented Jan 29, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Jan 29, 2018

Member

Thanks @nicknish 👍

Member

zeke commented Jan 29, 2018

Thanks @nicknish 👍

@nicknish

This comment has been minimized.

Show comment
Hide comment
@nicknish

nicknish Jan 29, 2018

Contributor

Thanks @zeke & @codebytere! 😄

Contributor

nicknish commented Jan 29, 2018

Thanks @zeke & @codebytere! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment