New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't inherit isBrowserView preference #11799

Merged
merged 1 commit into from Feb 1, 2018

Conversation

Projects
None yet
2 participants
@codebytere
Member

codebytere commented Feb 1, 2018

Resolves #11790.

Make it such that isBrowserView is non-inheritable to prevent child windows from being unable to be closed.

/cc @MarshallOfSound

@codebytere codebytere requested a review from electron/reviewers as a code owner Feb 1, 2018

@felixrieseberg

This comment has been minimized.

Member

felixrieseberg commented Feb 1, 2018

Something deep down in me wants a test for the property inheritance, but we don't need to do that in this PR.

@codebytere codebytere merged commit 1545a95 into master Feb 1, 2018

9 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@codebytere codebytere deleted the browserview-inherit-fix branch Feb 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment