New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixs some errors in the security documentation #11806

Merged
merged 1 commit into from Feb 2, 2018

Conversation

Projects
None yet
2 participants
@felixrieseberg
Member

felixrieseberg commented Feb 1, 2018

We found a few tiny errors and improvements:

  1. The checklist on top wasn't in the same order as the detailed explanations at the bottom
  2. Some links were broken
  3. Adding numbers make the list way easier to talk about

@felixrieseberg felixrieseberg requested a review from electron/docs as a code owner Feb 1, 2018

@ckerr

ckerr approved these changes Feb 2, 2018

👍

@ckerr ckerr merged commit bd06abd into master Feb 2, 2018

9 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@zeke zeke deleted the security-docs-improvements branch Feb 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment