New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix child touch bar items not updating #11812

Merged
merged 2 commits into from Feb 12, 2018

Conversation

Projects
None yet
4 participants
@MarshallOfSound
Member

MarshallOfSound commented Feb 2, 2018

Deep children of a TouchBar didn't cause the top level touch bar to update, now they do

Fixes #11761.

@MarshallOfSound MarshallOfSound requested a review from electron/reviewers as a code owner Feb 2, 2018

Fix child touch bar items not updating
Deep children of a TouchBar didn't cause the top level touch bar to update, now they do

Fixes #11761.
@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound Feb 2, 2018

Member

This PR also explicitly marks some properties we set on TouchBarItem's to be immutable (will throw an error if you try to set them) this is just to stop users breaking things 👍

Member

MarshallOfSound commented Feb 2, 2018

This PR also explicitly marks some properties we set on TouchBarItem's to be immutable (will throw an error if you try to set them) this is just to stop users breaking things 👍

@ckerr

Code basically LGTM.

Any chance of getting tests for this, or is that too hard to set up?

@codebytere

per @MarshallOfSound there doesn't really seem to be better way to do tests for this, so 👍

@codebytere codebytere merged commit 66b5785 into master Feb 12, 2018

8 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@codebytere codebytere deleted the fix-child-touch-bar-items branch Feb 12, 2018

sethlu added a commit to sethlu/electron that referenced this pull request May 3, 2018

Fix child touch bar items not updating (#11812)
* Fix child touch bar items not updating

Deep children of a TouchBar didn't cause the top level touch bar to update, now they do

Fixes #11761.

* Remove unused newValue property in TB setter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment