New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move locale doc to command line switches #11863

Merged
merged 4 commits into from Feb 8, 2018

Conversation

Projects
None yet
4 participants
@codebytere
Member

codebytere commented Feb 8, 2018

Moves locale documentation to command_line_switches and move test to chromium_spec.js

/cc @deepak1556

codebytere added some commits Feb 8, 2018

@codebytere codebytere requested review from electron/docs as code owners Feb 8, 2018

codebytere added some commits Feb 8, 2018

@deepak1556

👍

@ckerr

ckerr approved these changes Feb 8, 2018

LGTM

@codebytere codebytere merged commit 8b9b1e5 into master Feb 8, 2018

8 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@codebytere codebytere deleted the move-locale-test branch Feb 8, 2018

@@ -530,12 +530,6 @@ Returns `String` - The current application locale. Possible return values are do
**Note:** On Windows you have to call it after the `ready` events gets emitted.
### `app.setLocale(locale)`

This comment has been minimized.

@zeke

zeke Feb 9, 2018

Member

What became of this method?

@zeke

zeke Feb 9, 2018

Member

What became of this method?

This comment has been minimized.

@zeke

zeke Feb 9, 2018

Member

nvm, I see: #11469 (comment)

@zeke
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment