New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add accessory view for format picker #11873

Merged
merged 3 commits into from Feb 11, 2018

Conversation

Projects
None yet
2 participants
@codebytere
Copy link
Member

codebytere commented Feb 9, 2018

Resolves #10335.

Allows for saveDialog to list available file extensions in a format picker button. Tested locally on MacOS, sadly no real way to test this one programmatically.

Todo:

  • implement selector action to change extension in top textbar

@codebytere codebytere requested a review from electron/reviewers as a code owner Feb 9, 2018

@codebytere codebytere changed the title add accessory view for format picker [WIP] add accessory view for format picker Feb 9, 2018

@codebytere codebytere changed the title [WIP] add accessory view for format picker add accessory view for format picker Feb 10, 2018

@MarshallOfSound
Copy link
Member

MarshallOfSound left a comment

pending builds 👍

@codebytere codebytere merged commit 647f0f3 into master Feb 11, 2018

8 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@codebytere codebytere deleted the add-file-format-picker branch Feb 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment