New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to log atom ipc messages #11880

Merged
merged 2 commits into from Feb 12, 2018

Conversation

Projects
None yet
3 participants
@nitsakh
Contributor

nitsakh commented Feb 10, 2018

This PR adds the ability to log Atom* IPC messages along with chromium IPC messages. They were showing as UNKNOWN MSG earlier when running with the CHROME_IPC_LOGGING=1 env variable set for debug builds. Now the right messages and data show in the logs.

Some of the messages still are unknown, not sure which ones those are. But this PR leaves fewer unknowns.

@nitsakh nitsakh requested a review from electron/reviewers as a code owner Feb 10, 2018

@deepak1556

LGTM otherwise 👍

#include "content/public/common/content_ipc_logging.h"
#define IPC_LOG_TABLE_ADD_ENTRY(msg_id, logger) \
content::RegisterIPCLogger(msg_id, logger)
#include "atom/common/api/api_messages.h"

This comment has been minimized.

@deepak1556

deepak1556 Feb 10, 2018

Member

This can instead be #include atom/common/common_message_generator.h, which includes all ipc messages defined in electron.

This comment has been minimized.

@nitsakh

nitsakh Feb 11, 2018

Contributor

Nice. That's even better. Will change, thanks @deepak1556 .

@codebytere

This comment has been minimized.

Member

codebytere commented Feb 11, 2018

@nitsakh re-kicked CI, i'll merge when it goes green

@codebytere codebytere merged commit fae71f9 into electron:master Feb 12, 2018

8 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment