New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use Squirrel.Mac that supports CDN releases #11925

Merged
merged 4 commits into from Feb 16, 2018

Conversation

Projects
None yet
4 participants
@MarshallOfSound
Member

MarshallOfSound commented Feb 15, 2018

This doesn't actually include the Squirrel.Mac version bump, that needs to happen in electron-frameworks first 馃憤

This PR is backwards compatible with the old way of calling setFeedURL so no impact on existing consumers. The new object based API is just to allow easier expansion in the future, adding a long list of args just gets annoying especially when multiple are optional.

@MarshallOfSound MarshallOfSound requested review from electron/docs as code owners Feb 15, 2018

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Feb 15, 2018

Also this adds a few extra tests (written before the code change) to ensure backwards compatibility and to add test coverage of this particular module.

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Feb 15, 2018

Need to line up a electron-typescript-definitions change with this PR as well

Ref: electron/electron-typescript-definitions#94

@MarshallOfSound MarshallOfSound requested a review from zeke Feb 15, 2018

@MarshallOfSound MarshallOfSound requested a review from electron/reviewers as a code owner Feb 16, 2018

MarshallOfSound added some commits Feb 16, 2018

@zcbenz

zcbenz approved these changes Feb 16, 2018

Looks good to me.

@zcbenz zcbenz merged commit 67fa13d into master Feb 16, 2018

9 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@zcbenz zcbenz deleted the squirrel-mac-cdn branch Feb 16, 2018

@zeke

This comment has been minimized.

Member

zeke commented Feb 16, 2018

馃帀

@bpasero

This comment has been minimized.

Contributor

bpasero commented Feb 22, 2018

@MarshallOfSound @zeke is there any chance to get release notes for Squirrel as to which version Electron now updated to or what the new features are and how to use them?

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Feb 22, 2018

@bpasero The new version of Squirrel supports static update metadata (think dumping things on S3)

The docs for that are here: https://github.com/Squirrel/Squirrel.Mac#update-file-json-format

@bpasero

This comment has been minimized.

Contributor

bpasero commented Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment