Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official build for 1.8 #11955

Merged
merged 14 commits into from Feb 22, 2018

Conversation

Projects
None yet
5 participants
@alespergl
Copy link
Contributor

alespergl commented Feb 19, 2018

Verified that release builds on:

  • Linux ia32
  • Linux x64
  • Linux arm
  • Linux arm64
  • Linux mips64el
  • macOS x64
  • Windows ia32
  • Windows x64

Requires electron/libchromiumcontent#454

@alespergl alespergl requested review from as code owners Feb 19, 2018

@alespergl alespergl force-pushed the official_build branch from fd1460e to 5889bbe Feb 20, 2018

jkleinsc and others added some commits Feb 20, 2018

@alespergl alespergl referenced this pull request Feb 20, 2018

Merged

Official build for 1.8 #454

@alespergl

This comment has been minimized.

Copy link
Contributor Author

alespergl commented Feb 20, 2018

@jkleinsc Can we run test suite on the release build for this PR?

@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Feb 20, 2018

@alespergl release builds here:
Jenkins build request successful. Check build status at https://mac-ci.electronjs.org/job/electron-osx-x64-release/40/.
Jenkins build request successful. Check build status at https://mac-ci.electronjs.org/job/electron-mas-x64-release/45/.
Check https://circleci.com/gh/electron/electron/10679 for status. (electron-linux-arm64)
Check https://circleci.com/gh/electron/electron/10681 for status. (electron-linux-ia32)
Check https://circleci.com/gh/electron/electron/10680 for status. (electron-linux-arm)
Check https://circleci.com/gh/electron/electron/10678 for status. (electron-linux-mips64el)
Check https://circleci.com/gh/electron/electron/10682 for status. (electron-linux-x64)
AppVeyor release build request successful. Check build status at https://windows-ci.electronjs.org/project/AppVeyor/electron/build/1.0.2810

@alespergl

This comment has been minimized.

Copy link
Contributor Author

alespergl commented Feb 20, 2018

Linux x64 release build timed out. Seems the build is killed after 10 minutes, but linking of the official build can take longer. Maybe we need to increase the timeout value? @jkleinsc

Linux mips64el linker is failing with the following error. I haven't heard of this problem on master. Can the mips toolchain be upgraded? @zcbenz

[1206/1206] LINK electron
FAILED: ../../vendor/cross-gcc-4.9.3-n64-loongson-rc5.4/usr/bin/mips64el-loongson-linux-g++ -Wl,--whole-archive /home/builduser/project/vendor/download/libchromiumcontent/static_library/libmedia.a /home/builduser/project/vendor/download/libchromiumcontent/static_library/libbase.a /home/builduser/project/vendor/download/libchromiumcontent/static_library/libskia.a /home/builduser/project/vendor/download/libchromiumcontent/static_library/libwebkit.a /home/builduser/project/vendor/download/libchromiumcontent/static_library/libwebkitcore.a /home/builduser/project/vendor/download/libchromiumcontent/static_library/libnet.a /home/builduser/project/vendor/download/libchromiumcontent/static_library/libangle.a /home/builduser/project/vendor/download/libchromiumcontent/static_library/libservices.a /home/builduser/project/vendor/download/libchromiumcontent/static_library/libcomponents.a /home/builduser/project/vendor/download/libchromiumcontent/static_library/libcc.a /home/builduser/project/vendor/download/libchromiumcontent/static_library/libppapi.a /home/builduser/project/vendor/download/libchromiumcontent/static_library/libpdfium.a /home/builduser/project/vendor/download/libchromiumcontent/static_library/libwebkitbindings.a /home/builduser/project/vendor/download/libchromiumcontent/static_library/libwebrtc.a /home/builduser/project/vendor/download/libchromiumcontent/static_library/libwebkitmodules.a /home/builduser/project/vendor/download/libchromiumcontent/static_library/libchromiumcontent.a -Wl,--no-whole-archive -Wl,-z,noexecstack -Wl,-rpath=\$ORIGIN -rdynamic -L/home/builduser/project/vendor/debian_jessie_mips64-sysroot/usr/lib64 -L/home/builduser/project/vendor/debian_jessie_mips64-sysroot/lib64 -L/home/builduser/project/vendor/debian_jessie_mips64-sysroot/usr/lib64 -Wl,--export-dynamic -pthread --sysroot=/home/builduser/project/vendor/debian_jessie_mips64-sysroot  -Wl,-O1 -Wl,--as-needed -Wl,--gc-sections -Wl,-rpath=\$ORIGIN/lib/ -Wl,-rpath-link=lib/ -o electron -Wl,--start-group obj/atom/app/electron.atom_main.o obj/libelectron_lib.a obj/brightray/libbrightray.a obj/vendor/breakpad/libbreakpad_client.a -Wl,--end-group lib/libnode.so -lpthread -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lfontconfig -lfreetype -ldbus-1 -lX11-xcb -lxcb -lXi -lXcursor -lXdamage -lXrandr -lXcomposite -lXext -lXfixes -lXrender -lX11 -lXtst -lXss -lgconf-2 -lgmodule-2.0 -lglib-2.0 -lpulse /home/builduser/project/vendor/download/libchromiumcontent/static_library/libffmpeg.so -lasound -lcap -lcups -lrt -ldl -lresolv -lexpat
/home/builduser/project/vendor/cross-gcc-4.9.3-n64-loongson-rc5.4/usr/bin/../lib/gcc/mips64el-loongson-linux/4.9.3/../../../../mips64el-loongson-linux/bin/ld: BFD version 2.24 assertion fail ../../bfd/elf-strtab.c:200
@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Feb 21, 2018

Linux mips64el linker is failing with the following error. I haven't heard of this problem on master. Can the mips toolchain be upgraded? @zcbenz

I'll ask the mips64el developers, if not I'll try to work around this error.

@alespergl

This comment has been minimized.

Copy link
Contributor Author

alespergl commented Feb 21, 2018

I found that the mips issue can be mitigated by removing --as-needed from the linker command line. @jkleinsc could you re-run the release tests to validate? Thanks.

@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Feb 21, 2018

@alespergl release builds have been retriggered:
Jenkins build request successful. Check build status at https://mac-ci.electronjs.org/job/electron-osx-x64-release/41/.
Jenkins build request successful. Check build status at https://mac-ci.electronjs.org/job/electron-mas-x64-release/46/.
Check https://circleci.com/gh/electron/electron/10835 for status. (electron-linux-ia32)
Check https://circleci.com/gh/electron/electron/10837 for status. (electron-linux-mips64el)
Check https://circleci.com/gh/electron/electron/10839 for status. (electron-linux-x64)
Check https://circleci.com/gh/electron/electron/10836 for status. (electron-linux-arm)
Check https://circleci.com/gh/electron/electron/10838 for status. (electron-linux-arm64)
AppVeyor release build request successful. Check build status at https://windows-ci.electronjs.org/project/AppVeyor/electron/build/1.0.2842

@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Feb 21, 2018

A couple of the builds failed. I bumped up the timeout for the linux x64 build and fixed the issue with the mas build (the libcc static file was incorrectly named).

Jenkins build request successful. Check build status at https://mac-ci.electronjs.org/job/electron-mas-x64-release/lastBuild/.
Jenkins build request successful. Check build status at https://mac-ci.electronjs.org/job/electron-osx-x64-release/lastBuild/.
Check https://circleci.com/gh/electron/electron/10845 for status. (electron-linux-ia32)
Check https://circleci.com/gh/electron/electron/10846 for status. (electron-linux-x64)
Check https://circleci.com/gh/electron/electron/10847 for status. (electron-linux-arm64)
Check https://circleci.com/gh/electron/electron/10844 for status. (electron-linux-mips64el)
Check https://circleci.com/gh/electron/electron/10848 for status. (electron-linux-arm)
AppVeyor release build request successful. Check build status at https://windows-ci.electronjs.org/project/AppVeyor/electron/build/1.0.2843

@alespergl

This comment has been minimized.

Copy link
Contributor Author

alespergl commented Feb 21, 2018

@jkleinsc I think the Linux agent is short on memory. We had the same problem internally. Is there a swap file/partition on that system? Adding it should fix the current failure.

@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Feb 21, 2018

@alespergl we can use larger machines on CircleCI. I updated the CircleCI config to use the same machines we are using on master.

@alespergl alespergl changed the title [wip] Official build for 1.8 Official build for 1.8 Feb 21, 2018

@alespergl alespergl force-pushed the official_build branch from bc7e886 to d94970e Feb 22, 2018

@alespergl

This comment has been minimized.

Copy link
Contributor Author

alespergl commented Feb 22, 2018

This is ready for merging now.

@zcbenz

zcbenz approved these changes Feb 22, 2018

@zcbenz zcbenz merged commit 87d2571 into 1-8-x Feb 22, 2018

8 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-mips64el Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@zcbenz zcbenz deleted the official_build branch Feb 22, 2018

@ckerr

This comment has been minimized.

Copy link
Member

ckerr commented May 12, 2018

Fixes #11628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.