New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the cyclic reference in menu delegate #11967

Merged
merged 2 commits into from Feb 20, 2018

Conversation

Projects
None yet
3 participants
@zcbenz
Contributor

zcbenz commented Feb 20, 2018

This PR fixes the memory leak when using menus, closes #9823.

@zcbenz zcbenz requested a review from electron/reviewers as a code owner Feb 20, 2018

@ckerr ckerr merged commit dc62e51 into master Feb 20, 2018

9 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@ckerr ckerr deleted the fix-menu-cyclic-reference branch Feb 20, 2018

sethlu added a commit to sethlu/electron that referenced this pull request May 3, 2018

Fix the cyclic reference in menu delegate (electron#11967)
* Fix the cyclic reference in menu delegate

* Fix menu tests due to delegate change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment