New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove setExtraParameter for 2.0 #11972

Merged
merged 2 commits into from Feb 20, 2018

Conversation

Projects
None yet
3 participants
@codebytere
Copy link
Member

codebytere commented Feb 20, 2018

We previously deprecated crashReporter.setExtraParameter in favor of crashReporter.addExtraParameter and crashReporter.removeExtraParameter

This PR removes backwards compatibility for the old method in 2.0.

@codebytere codebytere requested review from electron/docs as code owners Feb 20, 2018

@ckerr

ckerr approved these changes Feb 20, 2018

@codebytere codebytere merged commit 98ba120 into master Feb 20, 2018

9 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@codebytere codebytere deleted the remove-setextra-param branch Feb 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment