New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove html/rtf methods marked for 2.0 #11973

Merged
merged 1 commit into from Feb 20, 2018

Conversation

Projects
None yet
3 participants
@codebytere
Member

codebytere commented Feb 20, 2018

We changed:
clipboard.readHtml, clipboard.writeHtml, clipboard.readRtf, clipboard.writeRtf
to
clipboard.readHTML, clipboard.writeHTML, clipboard.readRTF, clipboard.writeRTF
and kept the old methods for backwards compat.

This removes the old methods for 2.0.

@codebytere codebytere requested a review from electron/reviewers as a code owner Feb 20, 2018

@ckerr

ckerr approved these changes Feb 20, 2018

👍

@codebytere

This comment has been minimized.

Member

codebytere commented Feb 20, 2018

it's the same old graceful exit flake

@codebytere codebytere merged commit 6a3fde6 into master Feb 20, 2018

9 of 10 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@codebytere codebytere deleted the remove-clipboard-methods branch Feb 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment