New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer support bool param for setHighlightMode #11981

Merged
merged 1 commit into from Feb 20, 2018

Conversation

Projects
None yet
3 participants
@codebytere
Member

codebytere commented Feb 20, 2018

What it says on the tin, per 2.0 Breaking Changes

// Deprecated
tray.setHighlightMode(true)
// Replace with
tray.setHighlightMode('on')
  
// Deprecated
tray.setHighlightMode(false)
// Replace with
tray.setHighlightMode('off')

@codebytere codebytere requested a review from electron/reviewers as a code owner Feb 20, 2018

@ckerr

ckerr approved these changes Feb 20, 2018

@jkleinsc jkleinsc merged commit dcaff20 into master Feb 20, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@jkleinsc jkleinsc deleted the set-tray-highlightmode branch Feb 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment