New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly disable executable stack #11999

Merged
merged 2 commits into from Feb 21, 2018

Conversation

Projects
None yet
4 participants
@alespergl
Contributor

alespergl commented Feb 21, 2018

Executable stack is already (implicitly) not required by the current master build, but this PR makes it explicit and avoids regression in case some new raw assembly code is introduced which is not properly marked for non-executable stack.

As a bonus, I added --icf=all to reduce binary size on supported architectures.

@alespergl alespergl requested a review from electron/reviewers as a code owner Feb 21, 2018

@deepak1556

👍

@jkleinsc jkleinsc merged commit b4ae41b into master Feb 21, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@jkleinsc jkleinsc deleted the no_execstack branch Feb 21, 2018

@ckerr

This comment has been minimized.

Member

ckerr commented Feb 23, 2018

@alespergl thank you so much for doing this. 💚

@ckerr

This comment has been minimized.

Member

ckerr commented May 12, 2018

/trop run backport-to 1-7-x

@trop

This comment has been minimized.

Contributor

trop bot commented May 12, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "1-7-x" here we go! :D

@trop

This comment has been minimized.

Contributor

trop bot commented May 12, 2018

An error occurred while attempting to backport this PR to "1-7-x", you will need to perform this backport manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment