New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial: Surround the snap version in quotes #12000

Merged
merged 1 commit into from Feb 21, 2018

Conversation

Projects
None yet
3 participants
@kalikiana
Contributor

kalikiana commented Feb 21, 2018

The example YAML in the Snapcraft section of the tutorial contains a version number. Best practice here is to always surround the version in quotes to avoid trailing zeros being lost, ie. version: 2.10 would end up being parsed as version "2.1".

@kalikiana kalikiana requested a review from electron/docs as a code owner Feb 21, 2018

@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Feb 21, 2018

💖 Thanks for opening this pull request! 💖

typing cat

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

welcome bot commented Feb 21, 2018

💖 Thanks for opening this pull request! 💖

typing cat

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@zeke

zeke approved these changes Feb 21, 2018

Looks good to me. CI failures are probably unrelated.

@codebytere codebytere merged commit e8a5737 into electron:master Feb 21, 2018

9 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Feb 21, 2018

Congrats on merging your first pull request! 🎉🎉🎉

welcome bot commented Feb 21, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment