New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated API in tools/dump-version-info.js #12003

Merged
merged 2 commits into from Feb 22, 2018

Conversation

Projects
None yet
4 participants
@zcbenz
Contributor

zcbenz commented Feb 21, 2018

No description provided.

@zcbenz zcbenz requested a review from electron/reviewers as a code owner Feb 21, 2018

@@ -16,7 +16,7 @@ function getDate () {
function getInfoForCurrentVersion () {
var json = {}
json.version = process.versions['atom-shell']
json.version = process.versions['electron']

This comment has been minimized.

@MarshallOfSound

MarshallOfSound Feb 22, 2018

Member

Now the key doesn't have a dash I guess this can just be process.versions.electron

@zcbenz zcbenz merged commit f9c48e1 into master Feb 22, 2018

8 of 9 checks passed

ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@zcbenz zcbenz deleted the tools-new-api branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment