New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename api::Window to api::BrowserWindow #12004

Merged
merged 1 commit into from Feb 22, 2018

Conversation

Projects
None yet
2 participants
@zcbenz
Contributor

zcbenz commented Feb 22, 2018

This makes the C++ implementation name actually match the JavaScript exported name.

@zcbenz zcbenz requested a review from electron/reviewers as a code owner Feb 22, 2018

@zcbenz zcbenz merged commit 47950f7 into master Feb 22, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@zcbenz zcbenz deleted the window-rename branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment