New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve Menu and MenuItem testing #12015

Merged
merged 4 commits into from Feb 23, 2018

Conversation

Projects
None yet
2 participants
@codebytere
Member

codebytere commented Feb 22, 2018

Split MenuItem and Menu specs up and work to increase code coverage by adding tests for as-yes-untested functions.

Still To-Do:

  • clean up accelerator and label tests

@codebytere codebytere requested a review from electron/reviewers as a code owner Feb 22, 2018

@codebytere codebytere changed the title from improve menu tests to [WIP] improve menu tests Feb 22, 2018

@codebytere codebytere changed the title from [WIP] improve menu tests to improve menu tests Feb 22, 2018

@codebytere codebytere changed the title from improve menu tests to improve Menu and MenuItem testing Feb 22, 2018

@ckerr

(review forthcoming as soon as I have better connectivity. Marking as RC just to prevent merging before I get to throw in my 2 cents 😄 )

Show outdated Hide outdated spec/api-menu-item-spec.js

codebytere added some commits Feb 22, 2018

@ckerr

ckerr approved these changes Feb 23, 2018

Thanks for the changes!

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Feb 23, 2018

Member

continuous-integration/jenkins/pr-head failure is unrelated to this PR

Member

ckerr commented Feb 23, 2018

continuous-integration/jenkins/pr-head failure is unrelated to this PR

@ckerr ckerr merged commit 18362eb into master Feb 23, 2018

8 of 9 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@ckerr ckerr deleted the improved-menu-testing branch Feb 23, 2018

sethlu added a commit to sethlu/electron that referenced this pull request May 3, 2018

improve Menu and MenuItem testing (#12015)
* split menu/menuitem and add some tests

* fix ipc send issue

* feedback: make tests less brittle

* clean up MenuItem accelerator and label tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment