New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context menu click callback #12043

Merged
merged 1 commit into from Feb 26, 2018

Conversation

Projects
None yet
5 participants
@kaylie-alexa
Member

kaylie-alexa commented Feb 25, 2018

Fixes #11818

As a regression from d7bc127#diff-0a6d4ddeae086b5db6034ab060fc8d94 (thanks @codebytere for debugging help!), the click handler was no longer getting called from context menu items.

My guess is that closeCallback.Run(); suppressed itemSelected from getting called when menu closes too quickly -- but using the previous PostTask implementation queues the callback. Would appreciate any more thoughts/insights on this!

@kaylie-alexa kaylie-alexa requested a review from electron/reviewers as a code owner Feb 25, 2018

@felixrieseberg

I can confirm that this fixes the thing 👏 👏 👏

@codebytere codebytere merged commit cc608a3 into electron:master Feb 26, 2018

9 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@zeke

This comment has been minimized.

Member

zeke commented Feb 26, 2018

Thanks, @kaylieEB!

@ckerr

This comment has been minimized.

Member

ckerr commented Feb 26, 2018

Nice work @kaylieEB 👍

alexeykuzmin added a commit that referenced this pull request Mar 8, 2018

Merge pull request #12043 from kaylieEB/fix-menu-item
Fix context menu click callback

(cherry picked from commit cc608a3)

codebytere added a commit that referenced this pull request Mar 8, 2018

Merge pull request #12043 from kaylieEB/fix-menu-item (#12170)
Fix context menu click callback

(cherry picked from commit cc608a3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment