New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network delegate race condition in 2-0-x #12053

Merged
merged 3 commits into from Feb 26, 2018

Conversation

Projects
None yet
2 participants
@codebytere
Member

codebytere commented Feb 26, 2018

Fix network delegate race condition; backporting to 2-0-x branch.

#12044

/cc @ckerr @zcbenz

zcbenz added some commits Feb 26, 2018

Move the arguments instead of const referrencing
Safer and more efficient.

@codebytere codebytere requested a review from electron/reviewers as a code owner Feb 26, 2018

@codebytere codebytere changed the title from Fix Network delegate race to Fix network delegate race condition Feb 26, 2018

@codebytere codebytere changed the title from Fix network delegate race condition to Fix network delegate race condition in 2-0-x Feb 26, 2018

@zcbenz

zcbenz approved these changes Feb 26, 2018

@zcbenz zcbenz merged commit bd2ab27 into 2-0-x Feb 26, 2018

9 of 10 checks passed

ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@zcbenz zcbenz deleted the network-delegate-race branch Feb 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment