New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include backtrace i/o as a crash reporter backend option #12058

Merged
merged 1 commit into from Mar 5, 2018

Conversation

Projects
None yet
6 participants
@philfreo
Contributor

philfreo commented Feb 26, 2018

Note: I have no affiliation with this company - just thought this would be helpful for people looking for a way to get started quickly (it was for me).

@philfreo philfreo requested a review from electron/docs as a code owner Feb 26, 2018

@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Feb 26, 2018

💖 Thanks for opening this pull request! 💖

typing cat

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

welcome bot commented Feb 26, 2018

💖 Thanks for opening this pull request! 💖

typing cat

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@MarshallOfSound

LGTM, want to run it by @zeke though 😄

@felixrieseberg

This comment has been minimized.

Show comment
Hide comment
@felixrieseberg

felixrieseberg Feb 27, 2018

Member

Makes sense to me. We're happy with Backtrace and I think sharing that option is valuable.

Member

felixrieseberg commented Feb 27, 2018

Makes sense to me. We're happy with Backtrace and I think sharing that option is valuable.

Include backtrace i/o as a crash reporter backend option
Note: I have no affiliation with this company - just thought this would be helpful for people
@abelmathew

This comment has been minimized.

Show comment
Hide comment
@abelmathew

abelmathew Mar 2, 2018

appreciate the shout out @philfreo , bump @MarshallOfSound

abelmathew commented Mar 2, 2018

appreciate the shout out @philfreo , bump @MarshallOfSound

@poiru

poiru approved these changes Mar 2, 2018

@zeke

zeke approved these changes Mar 5, 2018

@MarshallOfSound MarshallOfSound merged commit b530d70 into electron:master Mar 5, 2018

9 of 10 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: macOS/pr-head This commit looks good
Details
@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Mar 5, 2018

Congrats on merging your first pull request! 🎉🎉🎉

welcome bot commented Mar 5, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment