New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dockMenu not being referenced in JavaScript #12062

Merged
merged 2 commits into from Feb 27, 2018

Conversation

Projects
None yet
4 participants
@zcbenz
Contributor

zcbenz commented Feb 27, 2018

This was not a problem until #11967 fixed the memory leak of menus.

Close #12002.

@zcbenz zcbenz requested a review from electron/reviewers as a code owner Feb 27, 2018

@codebytere codebytere merged commit 35cbe9d into master Feb 27, 2018

9 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@codebytere codebytere deleted the fix-dock-menu-gc branch Feb 27, 2018

@PalmerAL

This comment has been minimized.

Show comment
Hide comment
@PalmerAL

PalmerAL Feb 28, 2018

Contributor

@zcbenz Can this be backported to 2.0?

Contributor

PalmerAL commented Feb 28, 2018

@zcbenz Can this be backported to 2.0?

sethlu added a commit to sethlu/electron that referenced this pull request May 3, 2018

Fix dockMenu not being referenced in JavaScript (#12062)
* Fix dockMenu not being referenced in JavaScript

* spec: Test garbage collecting dock menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment