New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inAppPurchase API doc #12072

Merged
merged 2 commits into from Mar 2, 2018

Conversation

Projects
None yet
3 participants
@AdrienFery
Contributor

AdrienFery commented Feb 27, 2018

Followup to #11292

addTransactionsListener is no longer supported. Users have to listen for the transactions-updated event instead.

Update inAppPurchase API doc
`addTransactionsListener` is no longer supported. Users have to listen for the `transactions-updated` event instead.

@AdrienFery AdrienFery requested a review from electron/docs as a code owner Feb 27, 2018

Tweak `transactions-updated` timing description
Make the documentation edit suggested by @felixrieseberg and thumbs-upped by @AdrienFery
@ckerr

ckerr approved these changes Mar 2, 2018

Looks good to me. Thanks for the improvements! 👍

@ckerr ckerr merged commit 6d82966 into electron:master Mar 2, 2018

1 of 7 checks passed

ci/circleci: electron-linux-arm CircleCI is running your tests
Details
ci/circleci: electron-linux-arm64 CircleCI is running your tests
Details
ci/circleci: electron-linux-ia32 CircleCI is running your tests
Details
ci/circleci: electron-linux-x64 CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
jenkins: macOS/pr-head This commit is being built
Details
WIP ready for review
Details

@AdrienFery AdrienFery deleted the AdrienFery:patch-1 branch Mar 8, 2018

sethlu added a commit to sethlu/electron that referenced this pull request May 3, 2018

Update inAppPurchase API doc (#12072)
* Update inAppPurchase API doc

`addTransactionsListener` is no longer supported. Users have to listen for the `transactions-updated` event instead.

* Tweak `transactions-updated` timing description

Make the documentation edit suggested by @felixrieseberg and thumbs-upped by @AdrienFery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment