New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when setting dock menu (2.0.x) #12087

Merged
merged 2 commits into from Mar 1, 2018

Conversation

Projects
None yet
2 participants
@zcbenz
Contributor

zcbenz commented Mar 1, 2018

Backports #12062 to 2.0.x.

@zcbenz zcbenz requested a review from electron/reviewers as a code owner Mar 1, 2018

@zcbenz zcbenz merged commit 6d3f603 into 2-0-x Mar 1, 2018

9 of 10 checks passed

jenkins: macOS/pr-head This commit cannot be built
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@zcbenz zcbenz deleted the fix-dock-menu-gc-2-0-x branch Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment