New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protocol filtering of net.request for 1.8. #12100

Merged
merged 2 commits into from Mar 2, 2018

Conversation

Projects
None yet
4 participants
@jkleinsc
Copy link
Contributor

jkleinsc commented Mar 2, 2018

This backports #11804 to 1.8

Fix protocol filtering of net.request
net::URLRequest inherits from base::SupportsUserData, which allows
associating arbitrary data with the request. Use this mechanism as a
condition for filtering requests from custom protocols.

Close #11657

(cherry picked from commit bc76f35)

@jkleinsc jkleinsc requested a review from electron/reviewers as a code owner Mar 2, 2018

@jkleinsc jkleinsc force-pushed the fix-protocol-origin-filtering-1-8 branch from 8b04f8f to 120bc96 Mar 2, 2018

@jkleinsc jkleinsc merged commit c1dad25 into 1-8-x Mar 2, 2018

8 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-mips64el Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: macOS/pr-head This commit looks good
Details

@jkleinsc jkleinsc deleted the fix-protocol-origin-filtering-1-8 branch Mar 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment