New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] switch footnote links to regular links syntax #12103

Merged
merged 1 commit into from Mar 6, 2018

Conversation

Projects
None yet
3 participants
@sofianguy
Member

sofianguy commented Mar 2, 2018

quick fix for #12085

There are other docs that need the same fix, but this is a start.

@sofianguy sofianguy requested a review from electron/docs as a code owner Mar 2, 2018

@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Mar 2, 2018

💖 Thanks for opening this pull request! 💖

typing cat

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

welcome bot commented Mar 2, 2018

💖 Thanks for opening this pull request! 💖

typing cat

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@sofianguy sofianguy requested a review from zeke Mar 2, 2018

@zeke

zeke approved these changes Mar 2, 2018

Looks good to me. :shipit:

The longer term solution will be to add a fix to hubdown, the tool we use to convert Markdown to HTML in i18n and on the website.

@sofianguy

This comment has been minimized.

Show comment
Hide comment
@sofianguy

sofianguy Mar 3, 2018

Member

lol jk. Upon further inspection 🕵️‍♀️ , looks like it's just the boilerplate doc that had broken links. Haven't found any other pages with broken links. Weird

Member

sofianguy commented Mar 3, 2018

lol jk. Upon further inspection 🕵️‍♀️ , looks like it's just the boilerplate doc that had broken links. Haven't found any other pages with broken links. Weird

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere Mar 6, 2018

Member

@sofianguy is this ready for merge?

Member

codebytere commented Mar 6, 2018

@sofianguy is this ready for merge?

@sofianguy

This comment has been minimized.

Show comment
Hide comment
@sofianguy
Member

sofianguy commented Mar 6, 2018

@codebytere it is!

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere Mar 6, 2018

Member

failure's a flake; merging anyway!

Member

codebytere commented Mar 6, 2018

failure's a flake; merging anyway!

@codebytere codebytere merged commit 1413f22 into master Mar 6, 2018

9 of 10 checks passed

jenkins: macOS/pr-head This commit cannot be built
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Mar 6, 2018

Congrats on merging your first pull request! 🎉🎉🎉

welcome bot commented Mar 6, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@codebytere codebytere deleted the fix-broken-links branch Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment