New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional verbose switch '-v' to build script. #12118

Merged
merged 3 commits into from Mar 5, 2018

Conversation

Projects
None yet
2 participants
@ckerr
Member

ckerr commented Mar 5, 2018

This PR was requested by no-one and blocks nothing, but it does what it says on the tin.

If you want to see ninja's build commands so that you can look at each argument as a clue to why your build isn't behaving the way you thought it would, this is the patch for you.

ckerr added some commits Mar 5, 2018

@ckerr ckerr requested a review from electron/reviewers as a code owner Mar 5, 2018

Add --ninja-path switch.
For compatiblity with #12120
@jkleinsc

Looks good to me.

@ckerr

This comment has been minimized.

Member

ckerr commented Mar 5, 2018

jenkins: macOS/pr-head is failing due to an unrelated issue "app.exit(exitCode)
exits gracefully on macos" which is tracked at #12050

@ckerr ckerr merged commit 642dc96 into master Mar 5, 2018

8 of 9 checks passed

jenkins: macOS/pr-head This commit cannot be built
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@ckerr ckerr deleted the add-build-verbose-switch branch Mar 5, 2018

sethlu added a commit to sethlu/electron that referenced this pull request May 3, 2018

Add optional verbose switch '-v' to build script. (electron#12118)
* Add optional verbose switch '-v' to build script.

* Remove tracer comment.

* Add --ninja-path switch.

For compatiblity with electron#12120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment