New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dev tools window interfering with mouse forward #12132

Merged
merged 1 commit into from Mar 7, 2018

Conversation

Projects
None yet
3 participants
@andens
Contributor

andens commented Mar 5, 2018

Fixes a bug with mouse forwarding that was brought to my attention in #1335. The problem was that the dev tools window interfered with the tracking of the webview window handle, causing mouse moves to be forwarded to that window instead. This means that once forwarding began, it never returned.

Note that there is still an issue with docked dev tools, because if your application is in a state where it's ignoring mouse input, you can't interact with them. This happens because the entire window ignores input, and is thus a side-effect of the original mouse ignore implementation. Since I came across it, I figured I'll mention it in case somebody wonders in the future.

@andens andens requested a review from electron/reviewers as a code owner Mar 5, 2018

@codebytere

codebytere approved these changes Mar 6, 2018 edited

LGTM, thanks for this! i'll merge once CI goes green...the mac fail was a flake so it should pass this time

@codebytere codebytere merged commit 69e7afe into electron:master Mar 7, 2018

9 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: macOS/pr-head This commit looks good
Details

@andens andens deleted the andens:forwarding-bug-fix branch Mar 7, 2018

@andens

This comment has been minimized.

Show comment
Hide comment
@andens

andens Mar 7, 2018

Contributor

@codebytere Come to think of it, this also applies to 1.8.x. Is that something one would want to consider, and if so, is there anything I should do? I'm new to open-source collaboration and don't know what to do with things that apply to previous versions, but would gladly have some light shed on the subject.

Contributor

andens commented Mar 7, 2018

@codebytere Come to think of it, this also applies to 1.8.x. Is that something one would want to consider, and if so, is there anything I should do? I'm new to open-source collaboration and don't know what to do with things that apply to previous versions, but would gladly have some light shed on the subject.

@alexeykuzmin

This comment has been minimized.

Show comment
Hide comment
@alexeykuzmin

alexeykuzmin Mar 8, 2018

Contributor

@codebytere If you think the fix is correct and safe, we should probably cherry-pick it to 2-0-x and 1-8-x.

Contributor

alexeykuzmin commented Mar 8, 2018

@codebytere If you think the fix is correct and safe, we should probably cherry-pick it to 2-0-x and 1-8-x.

sethlu added a commit to sethlu/electron that referenced this pull request May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment