New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libchromiumcontent for 2-0-x #12133

merged 1 commit into from Mar 6, 2018


None yet
4 participants

jkleinsc commented Mar 5, 2018

Update to get electron/libchromiumcontent#463 security fix

@jkleinsc jkleinsc requested a review from electron/reviewers as a code owner Mar 5, 2018


ckerr approved these changes Mar 5, 2018

This CI failure looks like a flake, but I don't think it's one of the flakes that have been recurring so much lately. My vote is to merge but I'd like another opinion before doing so; so instead, reviewing as Approved despite the CI failure.

not ok 763 chromium feature navigator.serviceWorker should register for file scheme
  Error: done() invoked with non-Error: unexpected error : [object Object]
      at w.webContents.on (/Users/electron/workspace/ctron_org_electron_PR-12133-KMOCIPUKXWTTELJCMJ437CA5EUNMOLUT6I3EY4NEG5VQHAMX2DKA/spec/chromium-spec.js:142:11)
      at CallbacksRegistry.apply (/Users/electron/workspace/ctron_org_electron_PR-12133-KMOCIPUKXWTTELJCMJ437CA5EUNMOLUT6I3EY4NEG5VQHAMX2DKA/out/D/
      at EventEmitter.ipcRenderer.on (/Users/electron/workspace/ctron_org_electron_PR-12133-KMOCIPUKXWTTELJCMJ437CA5EUNMOLUT6I3EY4NEG5VQHAMX2DKA/out/D/
      at emitThree (events.js:136:13)
      at EventEmitter.emit (events.js:217:7)

This comment has been minimized.


codebytere commented Mar 6, 2018

@ckerr i've seen that as a flake before; i'll re-kick the build to be sure but it should pass

@alexeykuzmin alexeykuzmin merged commit 4bb10c1 into 2-0-x Mar 6, 2018

10 checks passed

WIP ready for review
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
continuous-integration/appveyor/branch AppVeyor build succeeded
continuous-integration/appveyor/pr AppVeyor build succeeded
jenkins: macOS/pr-head This commit looks good

@alespergl alespergl deleted the update-libcc branch Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment