Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NativeWindow (Part 2): NativeWindow is no longer WebContentsObserver #12140

Merged
merged 22 commits into from Mar 7, 2018

Conversation

Projects
None yet
2 participants
@zcbenz
Copy link
Member

zcbenz commented Mar 6, 2018

This is part of the changes to decouple NativeWindow from WebContents, so it would be possible for us to implement new APIs based on NativeWindow, e.g. providing APIs to create native GUI elements without using WebContents.

This PR removes WebContentsObserver from NativeWindow's super classes.

@zcbenz zcbenz requested a review from as a code owner Mar 6, 2018

@zcbenz zcbenz force-pushed the native-window-no-web-contents branch from 3c53f70 to 7846809 Mar 6, 2018

@deepak1556
Copy link
Member

deepak1556 left a comment

👍

@zcbenz zcbenz merged commit ea9d333 into master Mar 7, 2018

9 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: macOS/pr-head This commit looks good
Details

@zcbenz zcbenz deleted the native-window-no-web-contents branch Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.