Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getFocusedWindow return type #12149

Merged
merged 1 commit into from Mar 7, 2018

Conversation

Projects
None yet
2 participants
@br0nstein
Copy link
Contributor

br0nstein commented Mar 6, 2018

For the generated TypeScript definition to be correct, getFocusedWindow's type needs to indicate that it can return null.

@br0nstein br0nstein requested a review from as a code owner Mar 6, 2018

@welcome

This comment has been minimized.

Copy link

welcome bot commented Mar 6, 2018

💖 Thanks for opening this pull request! 💖

typing cat

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@ckerr

ckerr approved these changes Mar 7, 2018

Copy link
Member

ckerr left a comment

Thanks for the fix!

@ckerr ckerr merged commit f170914 into electron:master Mar 7, 2018

9 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: macOS/pr-head This commit looks good
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Mar 7, 2018

Congrats on merging your first pull request! 🎉🎉🎉

sethlu added a commit to sethlu/electron that referenced this pull request May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.