New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkbox in dialog not working (1-8-x) #12154

Merged
merged 1 commit into from Mar 7, 2018

Conversation

Projects
None yet
2 participants
@codebytere
Member

codebytere commented Mar 7, 2018

Backports #11658 to 1-8-x

@codebytere codebytere requested a review from electron/reviewers as a code owner Mar 7, 2018

@ckerr

ckerr approved these changes Mar 7, 2018

@ckerr ckerr merged commit d2adeda into 1-8-x Mar 7, 2018

9 of 10 checks passed

jenkins: macOS/pr-head This commit cannot be built
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-mips64el Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details

@codebytere codebytere deleted the checkbox-bugfix branch Mar 7, 2018

@release-notifier

This comment has been minimized.

release-notifier bot commented Mar 16, 2018

This PR landed in electron v1.8.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment