Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecations come >=1 major release before removal #12155

Merged
merged 2 commits into from Mar 7, 2018

Conversation

Projects
None yet
3 participants
@ckerr
Copy link
Member

ckerr commented Mar 7, 2018

This updates the "90 day guarantee" to a "one major release guarantee" to fit better with semver.

@ckerr ckerr requested a review from as a code owner Mar 7, 2018

@MarshallOfSound MarshallOfSound merged commit fdab98a into master Mar 7, 2018

9 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: macOS/pr-head This commit looks good
Details

@MarshallOfSound MarshallOfSound deleted the modify-deprecation-guarantee branch Mar 7, 2018

@alexeykuzmin

This comment has been minimized.

Copy link
Contributor

alexeykuzmin commented Mar 7, 2018

@ckerr It probably won't make much sense to backport it to 2-0-x, right? I want to remove it from the board.

@ckerr

This comment has been minimized.

Copy link
Member Author

ckerr commented Mar 8, 2018

@alexeykuzmin It has to be backported to 2-0-x otherwise our plans for removing API in 3.0 can't happen due to the 90 day clause.

(I'm hoping dateOf('3.0.0-beta.1') <= June)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.