New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More vibrancy fixes #12157

Merged
merged 1 commit into from Mar 7, 2018

Conversation

Projects
None yet
2 participants
@MarshallOfSound
Member

MarshallOfSound commented Mar 7, 2018

This is a follow up to #11886

  • Only set title bar to transparent when vibrant with a custom titlebar
  • Correctly set the transparent state of the GpuSwitcher so vibrancy works on reload
  • Document case where using frame: false without custom titleBarStyle and vibrant
More vibrancy fixes
* Only set title bar to transparent when vibrant with a custom titlebar
* Correctly set the transparent state of the GpuSwitcher so vibrancy works on reload
* Document case where using frame: false without custom titleBarStyle and vibrant

@MarshallOfSound MarshallOfSound requested review from electron/docs as code owners Mar 7, 2018

@codebytere codebytere merged commit 8c138e7 into master Mar 7, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: macOS/pr-head This commit looks good
Details

@codebytere codebytere deleted the further-vibrancy-fixes branch Mar 7, 2018

alexeykuzmin added a commit that referenced this pull request Mar 8, 2018

More vibrancy fixes (#12157)
* Only set title bar to transparent when vibrant with a custom titlebar
* Correctly set the transparent state of the GpuSwitcher so vibrancy works on reload
* Document case where using frame: false without custom titleBarStyle and vibrant

(cherry picked from commit 8c138e7)

codebytere added a commit that referenced this pull request Mar 8, 2018

More vibrancy fixes (#12157) (#12171)
* Only set title bar to transparent when vibrant with a custom titlebar
* Correctly set the transparent state of the GpuSwitcher so vibrancy works on reload
* Document case where using frame: false without custom titleBarStyle and vibrant

(cherry picked from commit 8c138e7)

sethlu added a commit to sethlu/electron that referenced this pull request May 3, 2018

More vibrancy fixes (electron#12157)
* Only set title bar to transparent when vibrant with a custom titlebar
* Correctly set the transparent state of the GpuSwitcher so vibrancy works on reload
* Document case where using frame: false without custom titleBarStyle and vibrant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment