New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More vibrancy fixes (#12157) #12171

Merged
merged 1 commit into from Mar 8, 2018

Conversation

Projects
None yet
5 participants
@alexeykuzmin
Contributor

alexeykuzmin commented Mar 8, 2018

  • Only set title bar to transparent when vibrant with a custom titlebar
  • Correctly set the transparent state of the GpuSwitcher so vibrancy works on reload
  • Document case where using frame: false without custom titleBarStyle and vibrant

(cherry picked from commit 8c138e7)

Fixes #12068.

More vibrancy fixes (#12157)
* Only set title bar to transparent when vibrant with a custom titlebar
* Correctly set the transparent state of the GpuSwitcher so vibrancy works on reload
* Document case where using frame: false without custom titleBarStyle and vibrant

(cherry picked from commit 8c138e7)

@alexeykuzmin alexeykuzmin requested review from electron/docs as code owners Mar 8, 2018

@codebytere codebytere merged commit 48e0689 into 2-0-x Mar 8, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: macOS/pr-head This commit looks good
Details

@codebytere codebytere deleted the cp-2-0-x/12157 branch Mar 8, 2018

@zeke

This comment has been minimized.

Member

zeke commented Mar 8, 2018

cc @tommoor

@SMotaal

This comment has been minimized.

SMotaal commented Mar 15, 2018

So it is a lot better in terms of rendering artifacts (excellent), but it still crashes at least under the following condition:

In preload script:

const {remote} = require('electron');
const browserWindow = remote.getCurrentWindow();
browserWindow.setVibrancy('selection') // doesn't matter which type

First load is OK, resizing is a little laggy but no crashing.

Once refreshed (R) resizing, moving or simply loosing focus crashes.

UPDATE: It also does not crash when simply passed as an option (ie new BrowserWindow({vibrancy: '…' })) so only for dynamically resetting it to the same value (I did not try other values on refresh)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment