New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix popup menu position (2.0) #12181

Merged
merged 1 commit into from Mar 8, 2018

Conversation

Projects
None yet
2 participants
@alespergl
Contributor

alespergl commented Mar 8, 2018

Backport of #12180

@alespergl alespergl requested a review from electron/reviewers as a code owner Mar 8, 2018

@alespergl alespergl requested a review from zcbenz Mar 8, 2018

@ckerr

ckerr approved these changes Mar 8, 2018

@ckerr ckerr merged commit 5471bc3 into 2-0-x Mar 8, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details
jenkins: macOS/pr-head This commit looks good
Details

@ckerr ckerr deleted the fix_popup_menu_position-2.0 branch Mar 8, 2018

@alespergl

This comment has been minimized.

Contributor

alespergl commented Mar 8, 2018

This probably fixes #12047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment