New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that a document has been created before sending IPC messages #12190

Merged
merged 4 commits into from Mar 14, 2018

Conversation

Projects
None yet
4 participants
@MarshallOfSound
Member

MarshallOfSound commented Mar 9, 2018

  • Reverts 370476c in favor of moving the previous logic to the new RenderFrameObserver instead of RenderViewObserver

Fixes #12045

馃帀

Ensure that a document has been created before sending IPC messages
* Reverts 370476c in favor of moving the previous logic to the new RenderFrameObserver instead of RenderViewObserver

Fixes #12045

@MarshallOfSound MarshallOfSound requested a review from zcbenz Mar 9, 2018

@MarshallOfSound MarshallOfSound requested a review from electron/reviewers as a code owner Mar 9, 2018

@deepak1556

This comment has been minimized.

Show comment
Hide comment
@deepak1556

deepak1556 Mar 9, 2018

Member

I will add changes from ch63 branch that does rvo->rfo transition here a31deca. It should fix the failing tests.

Member

deepak1556 commented Mar 9, 2018

I will add changes from ch63 branch that does rvo->rfo transition here a31deca. It should fix the failing tests.

@MarshallOfSound MarshallOfSound merged commit 8664dd2 into master Mar 14, 2018

9 of 10 checks passed

jenkins: arm64/pr-head This commit cannot be built
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: macOS/pr-head This commit looks good
Details

@MarshallOfSound MarshallOfSound deleted the fix-double-preload-master branch Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment