New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Mac build when enable_run_as_node==false #12196

Merged
merged 1 commit into from Mar 9, 2018

Conversation

Projects
None yet
3 participants
@alespergl
Contributor

alespergl commented Mar 9, 2018

The build fails on macOS when enable_run_as_node is turned off.

@alespergl alespergl requested a review from electron/reviewers as a code owner Mar 9, 2018

@jkleinsc jkleinsc merged commit f685e38 into master Mar 9, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details
jenkins: macOS/pr-head This commit looks good
Details

@jkleinsc jkleinsc deleted the fix_run_as_node branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment