New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed passing of exception to the system crash handler #12198

Merged
merged 1 commit into from Mar 14, 2018

Conversation

Projects
None yet
3 participants
@alespergl
Contributor

alespergl commented Mar 9, 2018

On Windows, when the Electron crash handler is enabled, the internal skip_system_crash_handler_ flag does not work. I.e. when the flag is cleared and the process crashes, the exception is handled by Breakpad and the process terminates.

This change passes the exception to the system handler (on both ia32 and x64) which invokes the default crash dialog box.

@alespergl alespergl requested a review from zcbenz Mar 9, 2018

@alespergl alespergl requested a review from electron/reviewers as a code owner Mar 9, 2018

@zcbenz

zcbenz approved these changes Mar 14, 2018

@zcbenz zcbenz merged commit 134872e into master Mar 14, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details
jenkins: macOS/pr-head This commit looks good
Details

@zcbenz zcbenz deleted the fix_crash_handler branch Mar 14, 2018

@trop

This comment has been minimized.

Contributor

trop bot commented Mar 14, 2018

We have automatically backported this PR to "1-8-x", please check out #12258

@trop

This comment has been minimized.

Contributor

trop bot commented Mar 14, 2018

We have automatically backported this PR to "2-0-x", please check out #12259

@trop trop bot added merged/2-0-x and removed target/2-0-x labels Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment