New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heading for README #12202

Merged
merged 1 commit into from Mar 9, 2018

Conversation

Projects
None yet
2 participants
@vanessayuenn
Contributor

vanessayuenn commented Mar 9, 2018

The electron/i18n module uses headings in each doc to separate it into sections, and it's not happy with the current headinglessness of README. 馃槃

@vanessayuenn vanessayuenn requested a review from electron/docs as a code owner Mar 9, 2018

@jkleinsc

Looks good to me!

@jkleinsc jkleinsc merged commit e085c01 into master Mar 9, 2018

7 of 11 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
jenkins: arm64/pr-head This commit is being built
Details
jenkins: macOS/pr-head This commit is being built
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details

@jkleinsc jkleinsc deleted the readme-heading branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment