Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser: fix preload loading twice in 2.x #12218

Merged
merged 1 commit into from Mar 14, 2018

Conversation

Projects
None yet
4 participants
@deepak1556
Copy link
Member

deepak1556 commented Mar 12, 2018

Backports #12190

/cc @MarshallOfSound

@deepak1556 deepak1556 requested a review from as a code owner Mar 12, 2018

@ckerr

This comment has been minimized.

Copy link
Member

ckerr commented Mar 12, 2018

Note, the CI failure in macOS/pr-head was a known flake being tracked at #12173

not ok 763 chromium feature navigator.serviceWorker should register for file scheme
  Error: done() invoked with non-Error: unexpected error : [object Object]
@zcbenz

zcbenz approved these changes Mar 14, 2018

@zcbenz zcbenz merged commit 9843ce7 into 2-0-x Mar 14, 2018

10 of 11 checks passed

jenkins: macOS/pr-head This commit cannot be built
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details

@zcbenz zcbenz deleted the backport_double_preload_2_0_patch branch Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.